Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to sort pending review table by Creation time #68

Open
fcrozat opened this issue Feb 21, 2023 · 6 comments
Open

Unable to sort pending review table by Creation time #68

fcrozat opened this issue Feb 21, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@fcrozat
Copy link

fcrozat commented Feb 21, 2023

It looks like some recent update / rewrite in UI dropped the ability to sort the pending review table using the different columns.

I'm not longer able to sort it by Creation time

@kraih kraih added the enhancement New feature or request label Feb 21, 2023
@kraih
Copy link
Member

kraih commented Feb 21, 2023

That's correct, the old table implementation was client side, and got too slow with the amount of data we have to handle these days. The new, faster implementation, will require sorting to be done server side on SQL level.

@fcrozat
Copy link
Author

fcrozat commented Feb 21, 2023

We might not need to allow columns sorting but in that case, the default should still be "creation" time (the current sorting is a bit strange, having "obs leap" at the top)

@kraih
Copy link
Member

kraih commented Feb 21, 2023

The current default sorting is based on priority, which is important for reviewers.

@kraih
Copy link
Member

kraih commented Feb 21, 2023

The obs#leap is mostly meaningless. That was a temporary fix for old data affected by a race condition in the cleanup code that mostly involved Factory to Leap requests. Just ignore that, once the requests are reviewed you won't see it again.

@kraih
Copy link
Member

kraih commented Feb 21, 2023

If sorting is particularly important for any existing workflows, please let me know, and i'll prioritise this feature accordingly.

@fcrozat
Copy link
Author

fcrozat commented Feb 21, 2023

Well, if we can get rid of the obs#leap one, we don't need custom sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants