Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] ⚠️ Bump ClusterCatalog API to v1 #380

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[HOLD] ⚠️ Bump ClusterCatalog API to v1 #380

wants to merge 1 commit into from

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 6, 2024 •
edited
Loading

Bumps ClusterCatalog API to v1

Closes #341

@perdasilva perdasilva requested a review from a team as a code owner September 6, 2024 14:54
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.35897% with 10 lines in your changes missing coverage. Please review.

Project coverage is 37.37%. Comparing base (87d1c39) to head (1e4f441).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/controllers/core/clustercatalog_controller.go 83.33% 4 Missing ⚠️
api/core/v1/zz_generated.deepcopy.go 0.00% 2 Missing ⚠️
internal/source/containers_image.go 71.42% 1 Missing and 1 partial ⚠️
cmd/manager/main.go 0.00% 1 Missing ⚠️
internal/webhook/cluster_catalog_webhook.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   37.37%   37.37%           
=======================================
  Files          15       15           
  Lines         923      923           
=======================================
  Hits          345      345           
  Misses        529      529           
  Partials       49       49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva
Copy link
Contributor Author

/hold until we are ready to release

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@perdasilva perdasilva marked this pull request as draft September 12, 2024 11:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
bump ClusterCatalog API to v1
1e4f441 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 16, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

promote API from v1alpha1 to v1
2 participants
@perdasilva @openshift-merge-robot