Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dap-repl buffer does not automatically close #7

Open
dohmjan opened this issue Apr 3, 2023 · 3 comments
Open

dap-repl buffer does not automatically close #7

dohmjan opened this issue Apr 3, 2023 · 3 comments

Comments

@dohmjan
Copy link

dohmjan commented Apr 3, 2023

Hello!
I am using nvim-dap with your nvim-dap-ui and lately also tried cmp-dap. I really like it, thank you!

Without cmp-dap, the repl buffer automatically closes when toggling/closing the dap-ui. The corresponding issue was raised here. Your workaround in this comment and your PR in nvim-dap both worked.
Now, after I included cmp-dap, the issue reappears. Could you imagine whether this is due to cmp-dap?

@rcarriga
Copy link
Owner

rcarriga commented Apr 9, 2023

By not closed do you mean it is still listed (i.e. appears in :ls)?

There's nothing in cmp-dap that would be do that, but perhaps nvim-cmp is doing something? I don't experience any issue with it however

@jaghaimo
Copy link

Yes. It doesn't exist until I select something from autocompletion in repl, then:
image

Finished the session and it's still there.

@oshevtsov
Copy link

I encountered the same behavior and could not find a quick fix. The temporary workaround I am using at the moment is to disable cmp-dap for [dap-repl] buffers (comment out "dap-repl" when setting up require("cmp").setup.filetype(...)) and rely on nvim-dap's completion suggestion via <C-x><C-o> (built-in omnifunc implementation).

oshevtsov added a commit to oshevtsov/dotfiles that referenced this issue Sep 24, 2023
Pending decision on whether it is possible to avoid creating a
long-lived dap-repl buffer that persists even when a session is closed.
See rcarriga/cmp-dap#7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants