Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions-rs is deprecated #754

Open
nastevens opened this issue May 7, 2024 · 7 comments
Open

Actions-rs is deprecated #754

nastevens opened this issue May 7, 2024 · 7 comments

Comments

@nastevens
Copy link
Member

Per https://github.com/actions-rs the actions-rs project is deprecated and unmaintained. The associated actions have started to raise numerous warnings and are likely to stop working entirely at some point. An unscientific survey of other Rust projects seems to indicate a migration to https://github.com/dtolnay/rust-toolchain, but I would like to get some consensus from the team before charging ahead with this. This may also be an opportunity to close out #671.

I'm opening this issue here since it affects at least 20 R-E repos across multiple subteams at the time of writing: https://github.com/search?q=org%3Arust-embedded+actions-rs&type=code.

@Rahix
Copy link

Rahix commented May 7, 2024

There is also actions-rust-lang/setup-rust-toolchain but I don't know how the two compare.

@newAM
Copy link
Member

newAM commented May 8, 2024

It was also pointed out to me that rustup can be used directly, it's included in the ubuntu runner images.

@jonathanpallant
Copy link
Contributor

I prefer to just use rustup.

@nastevens
Copy link
Member Author

Does anyone have repos they can point to as reference of good design using GHA? Bonus points if the repo is already testing a matrix of architectures and features.

@Emilgardis
Copy link
Member

svd2rust has a pretty good setup: https://github.com/rust-embedded/svd2rust/blob/6979dc40c2d812b6f4f0b4fc7a18c29233faaf85/.github/workflows/ci.yml#L50

@romancardenas
Copy link
Contributor

In riscv we use rust-toolchain with different targets, features, etc.

So far, it works pretty fine.

@jannic
Copy link
Member

jannic commented May 14, 2024

I updated several repos to dtolnay/rust-toolchain a while ago, eg.:

Not saying that this is the best approach, only noting that it seems to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants