Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put HttpResponse into good use #121

Open
jangko opened this issue Jul 19, 2022 · 0 comments
Open

Put HttpResponse into good use #121

jangko opened this issue Jul 19, 2022 · 0 comments

Comments

@jangko
Copy link
Contributor

jangko commented Jul 19, 2022

Currently HttpResponse is not being used anywhere, it would be very useful if we can put it into use like in chronos' HttpResponseRef.

Recently I found, chronos HttpRequestRef.getResponse along with it's returned HttpResponseRef is very helpful to implement CORS.

Why it is useful?
When dealing with CORS, there might be preflight request that can be responded immediately. But for simple CORS request, such as using GET or POST method, CORS handler do not respond immediately, but only add some headers to the response. There the HttpResponse will be handy.

HttpResponse* = ref object of HttpCommon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant