Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unit pass but debug log show suspicious "Connection isn't open, abortig close sequence!" #39

Open
jangko opened this issue May 27, 2021 · 1 comment
Assignees

Comments

@jangko
Copy link
Contributor

jangko commented May 27, 2021

in the CI, tests is run with debug log suppressed. but when we enable chronicles log, it start to produce alarming messages.
but the test still pass.

DBG 2021-05-27 10:37:29.261+07:00 Sending data to remote                     tid=1569 opcode=Text masked=true dataSize=11
DBG 2021-05-27 10:37:29.261+07:00 Sending data to remote                     tid=1569 opcode=Close masked=true dataSize=2
DBG 2021-05-27 10:37:29.261+07:00 Decoded new frame                          tid=1569 opcode=Text len=11 mask=true
DBG 2021-05-27 10:37:29.311+07:00 Decoded new frame                          tid=1569 opcode=Close len=2 mask=true
DBG 2021-05-27 10:37:29.311+07:00 Handling close sequence                    tid=1569 readyState=Open fin=true opcode=Close masked=true
DBG 2021-05-27 10:37:29.311+07:00 Sending data to remote                     tid=1569 opcode=Close masked=false dataSize=2
DBG 2021-05-27 10:37:29.311+07:00 Decoded new frame                          tid=1569 opcode=Close len=2 mask=false
DBG 2021-05-27 10:37:29.311+07:00 Handling close sequence                    tid=1569 readyState=Closing fin=true opcode=Close masked=false
DBG 2021-05-27 10:37:29.311+07:00 Connection isn't open, abortig close sequence! tid=1569 readyState=Closing fin=true opcode=Close masked=false
DBG 2021-05-27 10:37:29.311+07:00 Exception reading frame, dropping socket   tid=1569 exc="Incomplete data sent or received"
DBG 2021-05-27 10:37:29.311+07:00 Exception reading frames                   tid=1569 exc="Incomplete data sent or received"

many of test cases from tests/testwebsockets.nim show this message.
is this ok? or is this an indicator something goes wrong?
shouldn't we be more cautious about this?

@dryajov dryajov self-assigned this Jun 2, 2021
@dryajov
Copy link
Member

dryajov commented Jun 16, 2021

Closing flow needs to be revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants