Opening hours check date is updated when marked as not signed #4273
Comments
|
It is apparently added in 0279378 to prevent immediately asking whether opening hours are signed, but it seems to not be an ideal, and |
|
haven't contributed before, but i'd be keen to give this a go since it looks fairly simple :) |
|
Note after looking through #4284: If this gets implemented - when the user answered "has no opening hours sign" in the opening hours quest, then it would only be consistent if in that case also check_date:opening_hours:signed is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the 'Are these opening hours still correct?' quest, if the user selects 'No opening hours sign', then two changes are made:
opening_hours:signedis set tono, as expected, andcheck_date:opening_hoursis set to the current date.To me, updating
check_date:opening_hoursimplies that the opening hours are correct at the current time. But the since the opening hours haven't actually been checked, they could be wrong/out of date.How to Reproduce
Um, find an 'Are these opening hours still correct?' quest, and select 'No opening hours sign'.
Expected Behavior
I'm not sure exactly what the right thing to do here is. Maybe the current behaviour is actually the desired behaviour?
My suggestion would be to use
check_date:opening_hours:signedinstead, although I don't think this key exists yet and I don't know what the guidance is for when it's alright to introduce new keys.If I've understood the code, then the opening hours quest isn't shown when
opening_hours:signedisno.And setting
check_date:opening_hours:signedto the current date would stop the opening hours signed quest from being shown.Versions affected
v45.1
The text was updated successfully, but these errors were encountered: