Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC Swift refactoring PR #194

Open
Kyle-Ye opened this issue Oct 26, 2023 · 9 comments
Open

NFC Swift refactoring PR #194

Kyle-Ye opened this issue Oct 26, 2023 · 9 comments
Labels

Comments

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Oct 26, 2023

I'd like to know what's this repo's attitude towards the following kind PR:

  1. Using Swift/SwiftUI when adding new features.
  2. Fixing existing bug on ObjectiveC code and refactoring the relevant file to Swift.
  3. NFC-refactoring cleaning PR from ObjectiveC to Swift.

Thanks.

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 27, 2023

@tisfeng

@tisfeng
Copy link
Owner

tisfeng commented Oct 27, 2023

可以的,参见这里 #182 (comment) ,我们计划未来逐步使用 Swift 来写新功能模块。但目前我们团队几个人都不是很熟悉 Swift。

看起来你比较擅长 Swift,有兴趣加入我们,帮忙改造项目,一起向 Swift 过渡吗?

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 27, 2023

可以的,参见这里 #182 (comment) ,我们计划未来逐步使用 Swift 来写新功能模块。但目前我们团队几个人都不是很熟悉 Swift。

看起来你比较擅长 Swift,有兴趣加入我们,帮忙改造项目,一起向 Swift 过渡吗?

Sure. I've already made some commits some time ago. I'll make it a PR this weekend. 🚀

Kyle-Ye@a7aecfc#diff-a523cf088c57f174bc452393b88a037d453958db0d48129f4b5e0ca117b815cf

@Jerry23011
Copy link
Collaborator

可以的,参见这里 #182 (comment) ,我们计划未来逐步使用 Swift 来写新功能模块。但目前我们团队几个人都不是很熟悉 Swift。
看起来你比较擅长 Swift,有兴趣加入我们,帮忙改造项目,一起向 Swift 过渡吗?

Sure. I've already made some commits some time ago. I'll make it a PR this weekend. 🚀

Kyle-Ye@a7aecfc#diff-a523cf088c57f174bc452393b88a037d453958db0d48129f4b5e0ca117b815cf

欢迎!有兴趣接手#182 这个issue吗 😃

@tisfeng
Copy link
Owner

tisfeng commented Oct 28, 2023

也不用, @Kyle-Ye 你可以先用 Swift 写一个比较完整的功能,比如在项目中添加一项新服务——彩云小译,之前我就有这个想法 #26 (comment) ,它的翻译效果确实不错,这样我们其他人也可以在一边参考学习一下,我好久没写 Swift 了,语法都忘得差不多了。。

@Jerry23011 你可以等 @Kyle-Ye 添加完彩云小译后再做腾讯翻译,慢一点也没关系,我希望我们后面都能熟悉 Swift,用它来实现一些功能。

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 28, 2023

也不用, @Kyle-Ye 你可以先用 Swift 写一个比较完整的功能,比如在项目中添加一项新服务——彩云小译,之前我就有这个想法 #26 (comment) ,它的翻译效果确实不错,这样我们其他人也可以在一边参考学习一下,我好久没写 Swift 了,语法都忘得差不多了。。

@Jerry23011 你可以等 @Kyle-Ye 添加完彩云小译后再做腾讯翻译,慢一点也没关系,我希望我们后面都能熟悉 Swift,用它来实现一些功能。

👌

@dark2zhao
Copy link

想问一下如何加入开发组?可以联系一下我吗?

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Jul 12, 2024

I guess the best way to join is to add some non-trivial pull requests to earn your credit.

@tisfeng
Copy link
Owner

tisfeng commented Jul 12, 2024

@dark2zhao 你好,如果对这个项目感兴趣,可以先提交 PR 解决一些 issue,例如这个 #607 ,你可以在感兴趣的 issue 在下面留言,稍后我分配给你。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants