Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headless mode: Interpret ROMS as a file path instead of URL when headless #291

Open
torch2424 opened this issue May 15, 2019 · 0 comments
Open

Headless mode: Interpret ROMS as a file path instead of URL when headless #291

torch2424 opened this issue May 15, 2019 · 0 comments
Assignees
@torch2424
Labels
good first issue Good for newcomers Lib / JS Issues concerning the JS API of WasmBoy

Comments

@torch2424
Copy link
Owner

See #288

When loadROM accepts a string, it assumes that it is in a web browser, and should fetch the file and then load the bytes.

If we have headless enabled, or fetch is unavailble, we should require('fs') and load the file that way 😄
@torch2424 torch2424 added good first issue Good for newcomers Lib / JS Issues concerning the JS API of WasmBoy labels May 15, 2019
@torch2424 torch2424 self-assigned this May 15, 2019
@torch2424 torch2424 mentioned this issue May 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torch2424 torch2424

Labels
good first issue Good for newcomers Lib / JS Issues concerning the JS API of WasmBoy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@torch2424