Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] easier and more robust way to set theme for faency #439

Open
gndz07 opened this issue Jul 16, 2024 · 0 comments
Open

[RFC] easier and more robust way to set theme for faency #439

gndz07 opened this issue Jul 16, 2024 · 0 comments
Labels
kind/research This task is to search for a solution for a specific problem, and should result in a technical task.

Comments

@gndz07
Copy link
Member

gndz07 commented Jul 16, 2024

Description

Before v1.0.0-10, we could set theme for Faency via FaencyProvider quite easily, like so:

import { FaencyProvider } from '@traefiklabs/faency';

const App = () => <FaencyProvider primaryColor="$blue8">{/* your app */}</FaencyProvider>;

After this PR, this approach doesn't work anymore (the documentation inside readme is stale, cf #402). The changes brought by #278 was motivated by the 'flashing' of the theme color because the selected theme was not available on the server side.

We could discuss on how to redesign this implementation and how to initialize theme so that it'll be easy to use by user.

@gndz07 gndz07 added the kind/research This task is to search for a solution for a specific problem, and should result in a technical task. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/research This task is to search for a solution for a specific problem, and should result in a technical task.
Projects
None yet
Development

No branches or pull requests

1 participant