Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emptied lines instead of emptying only the contents of the line #664

Open
Bennet-Sunder opened this issue May 21, 2024 · 1 comment
Open

Remove emptied lines instead of emptying only the contents of the line #664

Bennet-Sunder opened this issue May 21, 2024 · 1 comment

Comments

@Bennet-Sunder
Copy link
Contributor

image (1)

Polyglot piranha currently empties a line instead of removing this line. This means we will have to manually delete all such blank lines post polyglot execution.

Running linters might not be straightforward on larger repositories as it might cleanup unmodified lines as well leading to a huge diff.
@Bennet-Sunder
Copy link
Contributor Author

@ketkarameya could you pls assign this to me, I'll have a look at fixing this.

@Bennet-Sunder Bennet-Sunder mentioned this issue May 28, 2024
Closed
@danieltrt danieltrt mentioned this issue Aug 22, 2024
Merged
stefanheule pushed a commit that referenced this issue Sep 2, 2024
@danieltrt @Bennet-Sunder
Fix for : Remove blank lines instead of emptying it's contents (#687)
7323a98 
Fixes the PR #667 for feature request #664

---------

Co-authored-by: Bennet Sunder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove blank lines instead of emptying it's contents freshworks/piranha
1 participant
@Bennet-Sunder