Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature "RingCryptoProvider" should use "ring" crate only #2

Open
rainliu opened this issue Aug 27, 2023 · 1 comment
Open

feature "RingCryptoProvider" should use "ring" crate only #2

rainliu opened this issue Aug 27, 2023 · 1 comment

Comments

@rainliu
Copy link
Member

rainliu commented Aug 27, 2023

in crypto/provider/ring/signature.rs

impl crate::crypto::provider::Signature for SignatureScheme { fn sign(&self, sign_key: &[u8], message: &[u8]) -> Result<Bytes> {

SignatureScheme::ECDSA_P256_SHA256 and SignatureScheme::ECDSA_P384_SHA384 currently are using the following four RustCrypto crates for sign functions.

"signature", "ecdsa", "p256", "p384"

https://docs.rs/ring/latest/ring/signature/struct.EcdsaKeyPair.html doesn't provide from_seed_unchecked like Ed25519KeyPair (https://docs.rs/ring/latest/ring/signature/struct.Ed25519KeyPair.html).

@rainliu
Copy link
Member Author

rainliu commented Aug 27, 2023

briansmith/ring#889 is still under review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant