Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to eslint-stylistic (ESLint 9 dropped formatting rules) #734

Open
Tracked by #757
Talent30 opened this issue Nov 4, 2023 · 5 comments
Open
Tracked by #757

Move to eslint-stylistic (ESLint 9 dropped formatting rules) #734

Talent30 opened this issue Nov 4, 2023 · 5 comments

Comments

@Talent30
Copy link

Talent30 commented Nov 4, 2023

Hi, @sindresorhus, First of all, thank you for maintaining this amazing project.

ESLint is deprecating all the formatting rules, providing us with two alternatives for migration.

  1. Remove all the formatting rules in xo. Instead, we recommend users to utilise a code formatter, such as Prettier. This is the recommended approach.
  2. Migrate all the formatting rules to ESLint Stylistic.

I am happy to help either way.

@sindresorhus
Copy link
Member

I plan to go with 2, but I don't see the point in doing it until ESLint actually hard-deprecates (with runtime warning) or removes the rules. It would be good to let ESLint Stylistic stabilize a bit first.

@Talent30
Copy link
Author

Talent30 commented Nov 9, 2023

Close this for now. Will reopen it again when ESLint 9 releases.

@Talent30 Talent30 closed this as completed Nov 9, 2023
@sindresorhus
Copy link
Member

I prefer to keep it open so I won't get more duplicates.

@sindresorhus sindresorhus reopened this Nov 9, 2023
@EdJoPaTo
Copy link
Contributor

Just to add a thought in here: Maybe a noStyle setting (similar to indent or semicolon) would be nice so people can use own formatters easier.

@sindresorhus
Copy link
Member

I don't plan any noStyle setting. There's already a prettier setting.

@fregante fregante mentioned this issue Jul 18, 2024
3 tasks
@fregante fregante changed the title Deprecation of Formatting Rules in ESLint v8.53 Move to eslint-stylistic (ESLint 9 dropped formatting rules) Oct 12, 2024
@fregante fregante marked this as a duplicate of #731 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants