Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move data utils to 📁Data #3258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zearin
Copy link
Contributor

@Zearin Zearin commented Apr 18, 2024

(redo of PR #3253 cause I need to practice git rebase)

Trying to keep all the data-related code in one place.

Trying to keep all the data-related code in one place.
@Zearin
Copy link
Contributor Author

Zearin commented Apr 26, 2024

@uncenter @zachleat : Would you be willing to give this a review?

Copy link
Contributor

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Zach agrees with this change all the file imports look to be updated correctly.

@Zearin
Copy link
Contributor Author

Zearin commented May 1, 2024

@zachleat We await only your blessing

@zachleat
Copy link
Member

Given that #3257 moved to use Util/Objects, I think Util/Data makes more sense here!

@zachleat zachleat added the needs-changes A pull request that requires additional changes before it can be merged. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-changes A pull request that requires additional changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants