support: allow override of ADAFLAGS, LDFLAGS, library soversion #585
Conversation
|
|
|
Thank you for your contributions! In order to merge them, we need you to sign the CLA. Regarding the commit messages: could you keep them wrapped at 76 columns? |
support/langkit_support.gpr
Outdated
| @@ -12,6 +12,14 @@ library project Langkit_Support is | |||
| Library_Kind_Param : Library_Kind_Type := external | |||
| ("LIBRARY_TYPE", external ("LANGKIT_SUPPORT_LIBRARY_TYPE", "static")); | |||
|
|
|||
| type OS_Kind is ("windows", "unix", "osx"); | |||
| OS : OS_Kind := External ("LANGKIT_SUPPORT_OS", "windows"); | |||
There was a problem hiding this comment.
We would like to keep things working with default options: please replace "windows" with "" here and adjust the rest of the patch to avoid defining Library_Version in that case?
There was a problem hiding this comment.
Thank you. Unfortunately, this does not work:
$ gprbuild -Psupport/langkit_support.gpr
langkit_support.gpr:16:04: no value defined for "os"
gprbuild: "support/langkit_support.gpr" processing failed
I suppose this is a bug in GPRbuild, sorry I didn’t check earlier. To workaround it, I would suggest to replace "" with "unknown" or similar.
asarhaddon
force-pushed
the
build-flags
branch
from
5d510ec
to
5a8f16a
Compare
|
@asarhaddon ping! We would love to merge this, but you need to answer @pmderodat 's last comment |
|
Hello. |
This looks like a good idea. Yes, let’s do it, thank you! |
|
Hello @asarhaddon, and sorry for taking so much time to get back to you. The patch looks almost good to me: could you just rename the Thank you in advance, |
All this would be useful when packaging the support library for Debian.
I have tried to copy the code from gnatcoll so that it also benefits windows and macos.
Thanks for considering.