Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keymaps for actions #78

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

arnevm123
Copy link
Contributor

While using the plugin I found some documentation missing, please let me know if something is not accurate

@arnevm123
Copy link
Contributor Author

arnevm123 commented Jun 15, 2024

Not sure if I think peek is implemented as "Checkpoint", as this seems to be a similar purpose?
Also if you think the added keymaps are not "Actions" I can put these in another table.
If you think any descriptions are wrong/ you have some suggestions I can change them.
Or feel free to edit them yourself if you find that easier 😄

@AdeAttwood
Copy link
Owner

Yea this looks good, you are correct about the checkpoint and peek this is inconsistent naming. I think we will park this until #81 is done. I would really love to use the ftplugin/ivy.lua pattern, however I don't think it will work amazing with the external plugin managers we have now.

I think I am just going to have to accept that there are not many of us still using vim packages.

@AdeAttwood
Copy link
Owner

@arnevm123 after some thought, I am going to get this in and remove "Pending" from the code base to try and make things more consistent.

I also think there is a conversation to be had around this table of actions, they way the actions are defined right now are a little too specific to file finding or another action you are going to a point in a file. I may try to find some time to make this more generic and align the language with the original emacs package.

Thanks again for all the suggestions and contributions ❤️

@AdeAttwood AdeAttwood merged commit 611aa54 into AdeAttwood:0.x Jun 27, 2024
5 checks passed
@arnevm123
Copy link
Contributor Author

No worries, thank you for this amazing plugin and listening to my suggestions!

When I first saw the plugin I thought it was already really big, as it looks amazing and works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants