Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Windows #90

Closed
wants to merge 3 commits into from
Closed

feat: Support Windows #90

wants to merge 3 commits into from

Conversation

ShaolunWang
Copy link
Contributor

Add windows support by checking dll instead of so or dylib on windows in libivy.lua

AdeAttwood
AdeAttwood requested changes Jul 23, 2024
View reviewed changes
Copy link
Owner

@AdeAttwood AdeAttwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind getting this in. I don't think we will officially support windows unless we get it running in CI. Looks like we need to fix up the commit message and fall back to vim.loop to maintain support with neovim V0.9

AdeAttwood pushed a commit that referenced this pull request Jul 24, 2024
@ShaolunWang @AdeAttwood
feat: support windows
f3585c8 
Summary:
Add windows support by checking `dll` instead of `so` or `dylib` on windows in `libivy.lua`

Author: @ShaolunWang
Imported From: #90

Test Plan: None provided provided by the author.

Differential Revision: https://ph.baln.co.uk/D7
@AdeAttwood
Copy link
Owner

Thanks, this has been merged in f3585c8

@AdeAttwood AdeAttwood closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdeAttwood AdeAttwood AdeAttwood requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaolunWang @AdeAttwood