rename "deposit" to "payout": instant deposit button & modal #9554
+46
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use "payout" in modal and button UI - Update code comments - Update component and type names - Update CSS classes and relevant CSS rules
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +16 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Moving this to Noting that I have still not tested manually, but I believe the automated tests should be all good now. As with all rename payouts changes, we'll need to decide how we merge/deploy these, until then this is blocked/should not merge. |
haszari
added
the
status: blocked
Manual test
|
nagpai
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
I did a manual test and a round of review at the current stage. The changes seem to work fine. I have a small nitpick about copy on the button. Else the renaming seems to be done correctly across the button and modal copy, component names and style names too.
| /* translators: %s: Monetary amount to deposit */ | ||
| __( 'Deposit %s now', 'woocommerce-payments' ), | ||
| /* translators: %s: Monetary amount to pay out */ | ||
| __( 'Pay out %s now', 'woocommerce-payments' ), |
There was a problem hiding this comment.
Pay out xxx now can confuse a merchant. To them it may seem that they need to pay out, wherease they are actually going to receive the amount. The copy on the button on the main overview page reads as Get xxx now. That sounds more unambiguous. What about using that?
There was a problem hiding this comment.
I wouldn't want to change this without consulting design first – this flow was designed this way. Previously it used deposit, so pay out (or maybe payout) IMO is consistent and clear. We're using payout to mean "merchant gets money" consistently in the UI, so I would hope that they aren't confused about the meaning here!
There was a problem hiding this comment.
@rogermattic are you ok with the instant payout modal button saying Pay out $nnn now? Let us know (in team slack channel) if you want to test this in context, i.e. walk through the flow.
Thanks for testing @nagpai – did you test full instant deposit flow? If not, let me know gaps so I can retest. Otherwise we could be good to go 🎉 |
6 tasks
I just tested the complete flow and found that we have this transient notice that would need to be updated too. I think this would be covered within
Everything else looks fine! |
|
Thanks @nagpai ! Based on your testing I think we're good to go here, so removing |
shendy-a8c
changed the base branch from
develop
to
feature/deposits-payouts-rename
shendy-a8c
removed
the
status: blocked
|
I removed the Let me know if it's blocked from something else. |
|
@shendy-a8c (or anyone) feel free to merge this (into feature branch) on my behalf! Otherwise I can merge tomorrow morning 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9542
to do
Work in progress this is close but untested. My local dev site is not currently eligible for instant payouts.Update: @nagpai has tested full flow, so I think we're good to go here.Changes proposed
Testing instructions
your store needs to be eligible for instant deposits
US.USD.4000000000000077to skip pending period (speeds up TPV requirement).how to test this PR
Payments > Overview.Get $12 nowshould appear on balances card.depositand all UI & copy is accurate and helpful 🌞npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge