-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace overview when site is with a pending migration #95497
base: trunk
Are you sure you want to change the base?
Conversation
Since the parent has an overflow hidden and a padding bottom it wasn't being respected.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
); | ||
} | ||
|
||
return ( | ||
<div className="hosting-features"> | ||
<div className="hosting-features__hero"> | ||
<HostingHero> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Components were extracted so that we could reuse them.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~210 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1897 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~50 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
When we implement the started status, we can also use the MigrationOverview, and remove this conditional.
a18a2c4
to
2150032
Compare
I added the "[Status] String Freeze" because we have many new texts, so we'll delay a little to merge this anyway. |
@@ -473,6 +473,7 @@ | |||
margin-top: 0; | |||
margin-left: 0; | |||
margin-right: 0; | |||
margin-bottom: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927618 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @renatho for including a screenshot in the description! This is really helpful for our translators. |
Related to #95379 and #95380
Proposed Changes
ref
ashosting-migration-overview
, so we can identify when the user is coming from this page.This PR Doesn't Include
@donnapep, do you think it's fine to deploy it as it is and implement these other parts in other PRs? I think one issue would be fine for both changes. I'll wait for your answer to then create the new issue, otherwise, I'll continue working on this one.
Why are these changes being made?
Testing Instructions
/setup/migration
./sites
./sites
and click on "Start your migration"./sites
./setup/hosted-site-migration
and make sure it works properly.Screenshots
Pre-merge Checklist