Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace overview when site is with a pending migration #95497

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 17, 2024

Related to #95379 and #95380

Proposed Changes

  • Extract some components from the "Hosting Features" tab, so we can reuse it.
  • It customizes the Sites overview with a button to continue the migration when it's pending.
  • The button contains a ref as hosting-migration-overview, so we can identify when the user is coming from this page.

This PR Doesn't Include

  • Disable other tabs from the menu.
  • Update the header when navigating to the site, similar to the changes we have in the listing.

@donnapep, do you think it's fine to deploy it as it is and implement these other parts in other PRs? I think one issue would be fine for both changes. I'll wait for your answer to then create the new issue, otherwise, I'll continue working on this one.

Why are these changes being made?

  • We want to offer a way for the users to continue their migration if they stopped in the middle.

Testing Instructions

Screenshots

Screenshot 2024-10-18 at 18 40 00

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

);
}

return (
<div className="hosting-features">
<div className="hosting-features__hero">
<HostingHero>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Components were extracted so that we could reuse them.

@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~210 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +499 B  (+0.0%)     +210 B  (+0.0%)
entry-main          +499 B  (+0.0%)     +210 B  (+0.0%)
entry-login         +283 B  (+0.0%)     +132 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1897 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
hosting                 +2654 B  (+0.1%)    +1440 B  (+0.3%)
hosting-features         +242 B  (+0.0%)     +193 B  (+0.0%)
site-monitoring          +133 B  (+0.0%)      +39 B  (+0.0%)
site-logs                +133 B  (+0.0%)      +39 B  (+0.0%)
settings                 +133 B  (+0.0%)      +50 B  (+0.0%)
github-deployments       +133 B  (+0.0%)      +46 B  (+0.0%)
staging-site              -61 B  (-0.0%)     +131 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~50 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-layout-command-palette       +133 B  (+0.1%)      +50 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@renatho renatho changed the title Add/site overview pending migration Replace overview when site is with a pending migration Oct 17, 2024
When we implement the started status, we can also use the MigrationOverview, and remove this conditional.
@renatho renatho force-pushed the add/site-overview-pending-migration branch from a18a2c4 to 2150032 Compare October 18, 2024 21:10
@renatho renatho added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 18, 2024
@renatho
Copy link
Contributor Author

renatho commented Oct 18, 2024

@donnapep, do you think it's fine to deploy it as it is and implement these other parts in other PRs? I think one issue would be fine for both changes. I'll wait for your answer to then create the new issue, otherwise, I'll continue working on this one.

I added the "[Status] String Freeze" because we have many new texts, so we'll delay a little to merge this anyway.

@renatho renatho marked this pull request as ready for review October 18, 2024 21:31
@renatho renatho requested a review from a team October 18, 2024 21:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@@ -473,6 +473,7 @@
margin-top: 0;
margin-left: 0;
margin-right: 0;
margin-bottom: auto;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the spacing at the bottom of the tabs.

Without this, it wasn't respecting the padding.

Screenshot 2024-10-18 at 18 32 26

@a8ci18n
Copy link

a8ci18n commented Oct 18, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927618

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @renatho for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
3 participants