Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odyssey Stats: Try direct public api calls #95501

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Oct 17, 2024

Related to #

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj added Stats Everything related to our analytics product at /stats/ DO NOT MERGE Odyssey Stats Calypso Stats in Jetpack labels Oct 17, 2024
@kangzj kangzj self-assigned this Oct 17, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug try/stats-wpcom-request-proxy on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Oct 17, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@kangzj kangzj changed the title Tyr: Odyssey Stats: Try direct public api calls Try: Odyssey Stats: Try direct public api calls Oct 17, 2024
@kangzj kangzj changed the title Try: Odyssey Stats: Try direct public api calls Odyssey Stats: Try direct public api calls Oct 18, 2024
@kangzj kangzj requested a review from a team October 18, 2024 05:25
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Odyssey Stats Calypso Stats in Jetpack Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants