feat: input-date: remove empty-text [GAUD-7027] #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaree
commented
Sep 30, 2024
| @@ -361,7 +351,6 @@ class InputDate extends FocusMixin(LabelledMixin(SkeletonMixin(FormElementMixin( | |||
|
|
|||
| _handleBlur() { | |||
| this._showInfoTooltip = true; | |||
| this._setFormattedValue(); // needed for case with empty text click on input-text then blur | |||
There was a problem hiding this comment.
Tested this out and it seems no longer needed with empty-text gone.
There was a problem hiding this comment.
Glad we put a comment there then!
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
approved these changes
Sep 30, 2024
| @@ -361,7 +351,6 @@ class InputDate extends FocusMixin(LabelledMixin(SkeletonMixin(FormElementMixin( | |||
|
|
|||
| _handleBlur() { | |||
| this._showInfoTooltip = true; | |||
| this._setFormattedValue(); // needed for case with empty text click on input-text then blur | |||
There was a problem hiding this comment.
Glad we put a comment there then!
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
This removes the
empty-textattribute, as well as all core references to it, frominput-date. This attribute is not used and so I've confirmed with Jeff that we want to clean it up as a part of the placeholder clean up work.