Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address validationError tooltip console for outputs #5088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KearseTrevor
Copy link
Contributor

@KearseTrevor KearseTrevor commented Oct 21, 2024

https://desire2learn.atlassian.net/browse/GAUD-7125

After reviewing all inputs that contain validationError and FormElementMixin

  • All applicable elements made use of the same pattern (using announced attribute)
  • Going to go with parity with other elements

Action: Add for attribute to input-text, leave announced for now

I'm open to have a quick conversation about removing the use of announced from the elements that make use of it in their validationError tooltips

  • When I removed it, and trialed it out - the behaviour appeared equivalent, but I'm unsure if it is our desired behaviour in either case for Safari + VO

@KearseTrevor KearseTrevor requested a review from a team as a code owner October 21, 2024 14:49
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5088/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant