-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Include the linux integration tests jobs #30272
base: main
Are you sure you want to change the base?
Conversation
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Gitlab CI Configuration ChangesAdded Jobs.integration_tests_deb.integration_tests_deb:
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache.tar.xz
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache_tools.tar.xz
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- go_tools_deps
stage: integration_test
tags:
- docker-in-docker:amd64 agent_integration_testsagent_integration_tests:
allow_failure: true
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache.tar.xz
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache_tools.tar.xz
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- go_tools_deps
retry: 2
script:
- inv -e integration-tests --race --remote-docker
stage: integration_test
tags:
- docker-in-docker:amd64
timeout: 30m docker_integration_testsdocker_integration_tests:
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache.tar.xz
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache_tools.tar.xz
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- go_tools_deps
script:
- inv -e docker.test
- inv -e docker.integration-tests
stage: integration_test
tags:
- docker-in-docker:amd64 Changes Summary
ℹ️ Diff available in the job log. |
[Fast Unit Tests Report] On pipeline 46919830 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
❌ MergeQueue: The build pipeline contains failing jobs for this merge request Build pipeline has failing jobs for e1fae7e: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. If you need support, contact us on Slack #devflow with those details! |
Regression DetectorRegression Detector ResultsRun ID: bea8c00f-5583-4047-aa49-e00772e22346 Metrics dashboard Target profiles Baseline: 53d7246 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +1.10 | [+0.29, +1.92] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.93 | [+0.21, +1.64] | 1 | Logs |
➖ | idle | memory utilization | +0.69 | [+0.64, +0.73] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.20 | [-0.04, +0.45] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.18 | [+0.00, +0.36] | 1 | Logs |
➖ | file_tree | memory utilization | +0.11 | [-0.02, +0.24] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.01] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.33, +0.32] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.09] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.24, +0.21] | 1 | Logs |
➖ | idle_all_features | memory utilization | -0.02 | [-0.15, +0.11] | 1 | Logs bounds checks dashboard |
➖ | basic_py_check | % cpu utilization | -0.05 | [-2.77, +2.68] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.29 | [-0.78, +0.20] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.66 | [-0.71, -0.61] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.36 | [-3.87, +1.15] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
✅ | idle | memory_usage | 10/10 |
✅ | idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
What does this PR do?
This PR includes the linux integration tests jobs.
Motivation
#29489 missed the include so the job didn't run.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes