Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise dcs to work on other distros #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iainlane
Copy link

No description provided.

Iain Lane added 2 commits August 16, 2013 15:13
  - Make dcs-unpack and computer-ranking accept a -dist parameter defaulting to
    'sid'
  - Search all components instead of just 'main'
@stapelberg
Copy link
Contributor

Thanks for the PR, I will look at it carefully and merge it on Sunday once I get home, unless it’s particularly urgent for you :).

@iainlane
Copy link
Author

OK. I think I forgot to mention or record in a separate commit that this changes dcs-unpack to use Directory: from the .dsc instead of constructing the path manually. I think it's nicer but didn't check on Debian if it works there (should do though from looking at some dsc files).

@stapelberg
Copy link
Contributor

Sorry that this is taking so long, but I’ve been swamped with emails and other work. I hope I can get to having a closer look at this PR in the next two or three days.

if _, err := os.Stat(oldPath); err == nil {
// Check whether the directory exists in the old "unpacked"
// directory and hardlink only if the new path doesn't exist
// (to avoid wasted time hardlinking in case of partial runs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I don’t like about this is that you need to cancel your runs on “directory boundaries”. I.e., if 3 of 5 files are unpacked, you cancel, the next run will skip the directory even though 2 files are still missing.

Handling this case properly is too complex, so that the entire optimization is not worth it. Can you remove it?

@stapelberg
Copy link
Contributor

In addition to the inline comments, I would appreciate it if you could do the refactoring in separate commits, so that it becomes clearer what you do :).

"strings"
)

var mirrorPath = flag.String("mirror_path",
"/media/sdd1/debian-source-mirror/",
"Path to the debian source mirror (which contains the 'dists' and 'pool' folder)")
var dist = flag.String("dist",
"sid",
"The release to scan")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of “release”, use “distribution” to stay consistent with the naming throughout DCS.

@iainlane
Copy link
Author

iainlane commented Oct 9, 2013

I'll try and get to this soon. Sorry for blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants