Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update free-courses-hi.md #11564

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update free-courses-hi.md #11564

wants to merge 5 commits into from

Conversation

Asjdnnc
Copy link

@Asjdnnc Asjdnnc commented Oct 15, 2024

Updated the code for the issue #11562

What does this PR do?

Add resource(s) - javascript course in hindi
Improve the free-courses-hi (Javascript section)

For resources

Javascript

Why is this valuable (or not)?

This courses is best for learning javascript for the beginners

How do we know it's really free?

It is available on youtube

It is the FREE youtube playlist

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Updated the code for the issue EbookFoundation#11562
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-hi.md
462:1-473:109  warning  Alphabetical ordering: swap l.465 and l.464                            alphabetize-lists  remark-lint
462:1-473:109  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 15, 2024
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-hi.md
462:1-473:132  warning  Alphabetical ordering: swap l.473 and l.472  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-hi.md
462:1-473:109  warning  Alphabetical ordering: swap l.471 and l.470  alphabetize-lists  remark-lint

fix the linter failed error
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-hi.md
462:1-473:109  warning  Alphabetical ordering: swap l.466 and l.465  alphabetize-lists  remark-lint

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 15, 2024
@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 15, 2024
@Asjdnnc
Copy link
Author

Asjdnnc commented Oct 17, 2024

@eshellman pls suggest the required changes if any?

@eshellman
Copy link
Collaborator

@eshellman pls suggest the required changes if any?

You removed a resource without explanation and omitted an author name

@Asjdnnc
Copy link
Author

Asjdnnc commented Oct 18, 2024

@eshellman
I removed the comprehensive WEB dev course playlist from the javascript section and replaced it with a dedicated javascript course from the same YouTube channel.

@eshellman
Copy link
Collaborator

The course you added has a different attribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants