Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imdb_sample recipe #193

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Add imdb_sample recipe #193

merged 1 commit into from
Jan 24, 2022

Conversation

Chandu-4444
Copy link
Contributor

@Chandu-4444 Chandu-4444 commented Jan 24, 2022

Hey, I tried to add the imdb_sample recipe to Tabular Datasets. Also, I added the correct hash value for the dataset to download.
Ref: #153

Umm... Are there any plans to make a /text folder (like fastai has) to put all the code related to text?

@lorenzoh
Copy link
Member

Looks good to me!

Umm... Are there any plans to make a /text folder (like fastai has) to put all the code related to text?

So I recently factored out all the vision- and tabular- related functionality into submodules Vision and Tabular. FastAI.jl doesn't yet have support for NLP tasks (though it could be integrated with the JuliaText ecosystem and Transformers.jl) so there hasn't been the need for a specific submodule yet.

@lorenzoh lorenzoh merged commit 406a850 into FluxML:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants