Skip to content

Commit

Permalink
Fix/cli alias collision (#184)
Browse files Browse the repository at this point in the history
  • Loading branch information
danibrutal authored Oct 4, 2024
1 parent 15f3de0 commit d3285f9
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/shiny-items-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-owl': patch
---

fix alias to avoid collision
14 changes: 7 additions & 7 deletions docs/cli/testing-the-app.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ Use the `test` command to run the app on the simulator, either comparing screens

#### Options

| Name | Required | Default | Options/Types | Description |
| ------------------------- | -------- | ----------------- | --------------- | ------------------------------------------------- |
| `--config`, `-c` | false | ./owl.config.json | String | Path to the configuration file |
| `--platform`, `-p` | true | - | `ios`,`android` | The platform the app should be built on |
| `--update`, `-u` | true | false | Boolean | A flag about rewriting existing baseline images |
| `--testNamePattern`, `-t` | false | false | String | Run only tests with a name that matches the regex |
| `--testPathPattern`, `-p` | false | false | String | A regexp string matched against all tests path |
| Name | Required | Default | Options/Types | Description |
| -------------------------- | -------- | ----------------- | --------------- | ------------------------------------------------- |
| `--config`, `-c` | false | ./owl.config.json | String | Path to the configuration file |
| `--platform`, `-p` | true | - | `ios`,`android` | The platform the app should be built on |
| `--update`, `-u` | true | false | Boolean | A flag about rewriting existing baseline images |
| `--testNamePattern`, `-t` | false | false | String | Run only tests with a name that matches the regex |
| `--testPathPattern`, `-tp` | false | false | String | A regexp string matched against all tests path |

When comparing images, any difference in the current vs baseline will fail the test.

Expand Down
2 changes: 1 addition & 1 deletion lib/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const testNamePattern: Options = {
};

const testPathPatternOption: Options = {
alias: 'p',
alias: 'tp',
describe: 'Run Test for a matching path pattern',
type: 'string',
default: '',
Expand Down

0 comments on commit d3285f9

Please sign in to comment.