This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Fix entrypoint trap handler #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tail prevents the SIGTERM signal from being handled by the trap at the top of the script. By using wait, it ensures that the signal is caught and handled by the trap.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, just wanted to suggest a simple addition to this script which fixes the trap handler. Tail prevents the SIGTERM signal from being handled by the trap at the top of the script. By using wait, it ensures that the signal is caught and handled by the trap.
For reference on the tail -f thing: https://stackoverflow.com/questions/49507830/sigterm-signal-not-caught-when-the-last-process-is-tail
PS: this is my first time making a pull request so im sorry if im pushing to the wrong branch or something. just really love this docker image and wanted to help :)