Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect href with subdir #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix incorrect href with subdir #9

wants to merge 2 commits into from

Conversation

rugk
Copy link

@rugk rugk commented May 16, 2016

Fixes #6

@rugk
Copy link
Author

rugk commented May 16, 2016

My second commit now fixes another issue:
With the first version both admin plugins I mentioned now failed to print the URL correctly. (they added another path to /customEtherpadSubDir/customAdminDir so it is /customEtherpadSubDir/customAdminDir/admin.

Now it works, but it does not have to work in every Etherpad installation. This is probably why the other plugins have prefix handling.

@Gared
Copy link
Owner

Gared commented May 18, 2016

If you're on the "Troubleshooting information" page, the link to "Message to all" is broken.
After I had a deeper look into the code this is a problem how etherpad build urls and should be fixed there for all plugins.

@rugk
Copy link
Author

rugk commented May 19, 2016

So have you found/opened an issue in the Etherpad repo?

@Gared
Copy link
Owner

Gared commented May 19, 2016

@rugk Not yet. You can create an issue if you want

@rugk
Copy link
Author

rugk commented May 19, 2016

Well... I think you can describe the issue better as you dug into the code. 😄

@Gared
Copy link
Owner

Gared commented Jun 9, 2016

Just created a ticket: ether/etherpad-lite#3001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants