Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter undefined values from schema.allOf when generating schema example #2442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vibhanshub
Copy link
Contributor

@vibhanshub vibhanshub commented Aug 30, 2024

Filter undefined values from schema.allOf when generating schema example

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: b349a81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 36 changed, 112 removed, 28 failures Aug 30, 2024, 1:51 PM

if (schema.allOf && schema.allOf.length > 0) {
return schema.allOf.reduce(

const filteredAllOf = schema.allOf && schema.allOf.filter(item => item !== undefined)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some more context on the issue you are fixing?

How can we end up with allOf items being undefined? Does the spec allow it?
I thought that the allOf should be a list of schema object or references to schema object, typed like this for example:

(ReferenceObject | SchemaObject)[]

Is this an issue in resolving a schema reference maybe? To me sounds more like something we should fix at the schema parsing level rather than having to filter undefined at this level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants