Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FormulaInstaller OS extensions #18275

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Sep 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

(Vaguely) relates to: #17998

It looks like these OS extensions, introduced in #14163, were not required from formula_installer, so are not actually in use. I fixed that issue, and added some tests intended to prevent a regression. (I don't think I've added OS-specific tests before, so I'm not sure how the magic works, or what assumptions can be made within them, so apologies if this is a bumpy ride.)

@dduugg dduugg requested review from MikeMcQuaid and apainintheneck and removed request for MikeMcQuaid September 6, 2024 21:04
@apainintheneck
Copy link
Contributor

😅 Thanks for catching this! I'm glad it only seems like it affected messaging and not formula installs themselves.

@dduugg dduugg merged commit faed92b into master Sep 7, 2024
27 checks passed
@dduugg dduugg deleted the use-formula-installer-os-extensions branch September 7, 2024 15:09
@MikeMcQuaid
Copy link
Member

Thanks @dduugg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants