Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict typing in FormulaInstaller #18290

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Sep 8, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

relates to #17297 #17998

Library/Homebrew/formula_installer.rb Show resolved Hide resolved
Library/Homebrew/formula_installer.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_installer.rb Show resolved Hide resolved
@dduugg dduugg force-pushed the strict-formula-installer branch 5 times, most recently from a4b063e to bec4d57 Compare September 9, 2024 01:36
@MikeMcQuaid
Copy link
Member

Thanks @dduugg! Good to merge when conflicts addressed.

Library/Homebrew/formula_installer.rb Outdated Show resolved Hide resolved
@dduugg dduugg changed the title Strict type FormulaInstaller Enable strict typing in FormulaInstaller Sep 10, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dduugg!

@dduugg dduugg merged commit 5b0a84b into master Sep 10, 2024
27 checks passed
@dduugg dduugg deleted the strict-formula-installer branch September 10, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants