-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula: add size information to JSON API #18403
base: master
Are you sure you want to change the base?
Conversation
For cases like this:
This means the diff/CI will be correct and it'll fall through to targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Good to go when ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually: not seeing where this is added to JSON API yet but assuming that's coming later.
As we discussed before I think it makes sense to:
- have multiple sizes across the variations when they are available
- consider having a top-level size key that is the only size if only one is available and something like the mean size if multiple are?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Will be using this PR to essentially jot some ideas down. Needs #18172 beforehand. May end up combining parts of this into other PR.
brew fetch
so we can make use of--concurrency
with new--only-manifests
to pull quickly pull down all formulae manifests.