Deprecate installing casks/formulae from paths. #18409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Sep 25, 2024
@carlocab I'm pretty sure it does not but CI will test this (and I'll test locally too to be safe). We already have a loader for handling bottles and another for handling paths that's used internally: both of those are still ok. Note to self: also check that this does actually disable formulae from |
MikeMcQuaid
force-pushed
the
deprecate_formula_cask_path_url
branch
from
816186b
to
c2496b8
Compare
Checked: it now does. |
MikeMcQuaid
force-pushed
the
deprecate_formula_cask_path_url
branch
2 times, most recently
from
e493398
to
8b87bfe
Compare
MikeMcQuaid
force-pushed
the
deprecate_formula_cask_path_url
branch
from
8b87bfe
to
7c62015
Compare
We've already disabled installing casks/formulae from URLs and we regularly tell people not to install from paths so let's just deprecate this behaviour entirely. Even Homebrew developers do not need to work this way.
MikeMcQuaid
force-pushed
the
deprecate_formula_cask_path_url
branch
from
7c62015
to
bbdea29
Compare
p-linnane
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already disabled installing casks/formulae from URLs and we regularly tell people not to install from paths so let's just deprecate this behaviour entirely.
Even Homebrew developers do not need to work this way.
Potential alternative to #18379 or at least a companion.