Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix livecheck of Google Chrome #175494

Closed
wants to merge 1 commit into from
Closed

fix livecheck of Google Chrome #175494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Casks/g/google-chrome.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@
homepage "https://www.google.com/chrome/"

livecheck do
url :url
strategy :extract_plist do |versions|
versions.values.filter_map(&:short_version).first
end
url "https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Mac"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been used previously, but caused issues

#142457

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this url?
https://chromiumdash.appspot.com/releases?platform=Mac

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concern is because the download url is disconnected to these feeds, and this is updated regularly. The livecheck is likely to often be out of sync at audit time.

This may be a rare case where extract_plist is actually the best option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point

regex(/"version":\s*"v?(\d+(?:\.\d+)+)"/i)
end

auto_updates true
Expand Down
Loading