Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm-performance-libraries 24.10 #189072

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

krehel
Copy link
Member

@krehel krehel commented Oct 19, 2024

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Oct 19, 2024
@krehel krehel force-pushed the bump-arm-performance-libraries-24.10 branch from ab1385a to ef9746b Compare October 19, 2024 02:40
@samford
Copy link
Member

samford commented Oct 19, 2024

This is failing brew audit because the cask url returns two Content-Type headers in the response:

$ curl -IL https://developer.arm.com/-/cdn-downloads/permalink/Arm-Performance-Libraries/Version_24.10/arm-performance-libraries_24.10_macOS.tgz
HTTP/2 200
content-type: text/plain
last-modified: Tue, 15 Oct 2024 11:42:11 GMT
server: AkamaiNetStorage
cache-control: max-age=635
expires: Sat, 19 Oct 2024 19:55:39 GMT
date: Sat, 19 Oct 2024 19:45:04 GMT
content-type: application/octet-stream

Related code in #curl_http_content_headers_and_checksum expects one Content-Type header but #parse_curl_output will return an array (instead of a string) when a header appears more than once in a given response, as is the case here.

If I'm not mistaken, having multiple Content-Type headers isn't correct HTTP behavior but it seems like we'll have to work around it anyway. What's correct may be server-dependent but we could just use the last Content-Type header when the value is an array. I'll open a brew PR with a workaround in a moment (Homebrew/brew#18596).

@samford samford force-pushed the bump-arm-performance-libraries-24.10 branch from ef9746b to 5dffb47 Compare October 20, 2024 18:36
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passed CI now that the brew change is merged but someone else will have to approve this (since I'm the last pusher).

@samford samford added the ready to merge PR can be merged once CI is green label Oct 20, 2024
@bevanjkay bevanjkay merged commit 5cd8edc into master Oct 20, 2024
7 checks passed
@bevanjkay bevanjkay deleted the bump-arm-performance-libraries-24.10 branch October 20, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants