Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-certifi: rename to certifi #165433

Merged
merged 165 commits into from
Mar 8, 2024
Merged

python-certifi: rename to certifi #165433

merged 165 commits into from
Mar 8, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Will be a follow up to #165432.

This assumes that brew's rename logic can handle this properly.

EDIT: need to fix up the ordering. Sadly, I think brew style --fix will break any comments so will need to follow up if I use that option.

@cho-m cho-m added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. blocked labels Mar 7, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request python Python use is a significant feature of the PR or issue labels Mar 7, 2024
@cho-m cho-m added the python-vendoring Part of the Python resource vendoring project label Mar 7, 2024
@p-linnane p-linnane removed blocked automerge-skip `brew pr-automerge` will skip this pull request labels Mar 7, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 7, 2024
@cho-m cho-m marked this pull request as ready for review March 8, 2024 00:16
@cho-m
Copy link
Member Author

cho-m commented Mar 8, 2024

I think this should work even without bottles.

At least brew upgrade will autohandle it:

brew install snakemake
==> Downloading https://ghcr.io/v2/homebrew/core/snakemake/manifests/8.5.5
...gh pr checkout 165433 --force
Switched to branch 'certifi-rename'
HEAD is now at 7c6a17dba89 zabbix-cli: rename `python-certifi` to `certifi`brew upgrade
Running `brew update --auto-update`...
==> Auto-updated Homebrew!
Updated 2 taps (homebrew/command-not-found and homebrew/core).

You have 1 outdated formula installed.
==> Migrating formula python-certifi to certifi
==> Unlinking python-certifi
==> Moving python-certifi versions to /opt/homebrew/Cellar/certifi
==> Relinking certifi

Other things I've tried seem to work, like just installing a different formula

brew install snakemake
==> Downloading https://ghcr.io/v2/homebrew/core/snakemake/manifests/8.5.5gh pr checkout 165433 --force
Switched to branch 'certifi-rename'
HEAD is now at 7c6a17dba89 zabbix-cli: rename `python-certifi` to `certifi`brew install sphinx-doc
==> Downloading https://ghcr.io/v2/homebrew/core/sphinx-doc/manifests/7.2.6_2-3
########################################################################################################################################################## 100.0%
==> Fetching dependencies for sphinx-doc: certifi
==> Downloading https://ghcr.io/v2/homebrew/core/certifi/manifests/2024.2.2
Already downloaded: /Users/cho-m/Library/Caches/Homebrew/downloads/02093bb105fb5bd7c9c6d3416050ad730e9bc91e187a0eac203e804168511726--certifi-2024.2.2.bottle_manifest.json
==> Fetching certifi
==> Downloading https://ghcr.io/v2/homebrew/core/certifi/blobs/sha256:b9fe35ba7ec714a11ee069f140a5dc362204741d3e11f06319d13b90284e85c9
Already downloaded: /Users/cho-m/Library/Caches/Homebrew/downloads/e57d450d25d46e22ccbe856b6b7d85941dd5c60afe3d3c9308649e02dd9680c7--certifi--2024.2.2.arm64_sonoma.bottle.tar.gz
==> Fetching sphinx-doc
==> Downloading https://ghcr.io/v2/homebrew/core/sphinx-doc/blobs/sha256:d67deb11b71d484b636d56949b9aadc0b1712aeb08a0fed018cba360116e4149
########################################################################################################################################################## 100.0%
==> Installing dependencies for sphinx-doc: certifi
==> Installing sphinx-doc dependency: certifi
==> Downloading https://ghcr.io/v2/homebrew/core/certifi/manifests/2024.2.2
Already downloaded: /Users/cho-m/Library/Caches/Homebrew/downloads/02093bb105fb5bd7c9c6d3416050ad730e9bc91e187a0eac203e804168511726--certifi-2024.2.2.bottle_manifest.json
==> Pouring certifi--2024.2.2.arm64_sonoma.bottle.tar.gz
🍺  /opt/homebrew/Cellar/certifi/2024.2.2: 30 files, 24.5KB
==> Installing sphinx-doc
==> Pouring sphinx-doc--7.2.6_2.arm64_sonoma.bottle.3.tar.gz
...ls -altr /opt/homebrew/lib/python3.12/site-packages/certifi/
total 0
drwxr-xr-x  7 cho-m admin 224 Mar  7 19:21 .
drwxr-xr-x 29 cho-m admin 928 Mar  7 19:21 ..
lrwxr-xr-x  1 cho-m admin  84 Mar  7 19:21 __init__.py -> ../../../../Cellar/certifi/2024.2.2/lib/python3.12/site-packages/certifi/__init__.py
lrwxr-xr-x  1 cho-m admin  84 Mar  7 19:21 __main__.py -> ../../../../Cellar/certifi/2024.2.2/lib/python3.12/site-packages/certifi/__main__.py
lrwxr-xr-x  1 cho-m admin  83 Mar  7 19:21 cacert.pem -> ../../../../Cellar/certifi/2024.2.2/lib/python3.12/site-packages/certifi/cacert.pem
lrwxr-xr-x  1 cho-m admin  80 Mar  7 19:21 core.py -> ../../../../Cellar/certifi/2024.2.2/lib/python3.12/site-packages/certifi/core.py
lrwxr-xr-x  1 cho-m admin  81 Mar  7 19:21 py.typed -> ../../../../Cellar/certifi/2024.2.2/lib/python3.12/site-packages/certifi/py.typed

@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 8, 2024
@p-linnane p-linnane added this pull request to the merge queue Mar 8, 2024
Merged via the queue into master with commit 4d201d2 Mar 8, 2024
21 checks passed
@p-linnane p-linnane deleted the certifi-rename branch March 8, 2024 00:32
@glensc
Copy link
Contributor

glensc commented Mar 31, 2024

why?

@cho-m
Copy link
Member Author

cho-m commented Apr 1, 2024

why?

It is part of #157500 and alignment to our standard naming. Almost all python-* formula (excluding python-tk, python-launcher, etc) were created outside our guidelines.

This will be made more obvious/explicit in Homebrew/brew#16662

@github-actions github-actions bot added the outdated PR was locked due to age label May 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants