Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #0318: Using navPlace and navDate Together #407

Merged
merged 24 commits into from
Aug 9, 2024
Merged

Recipe #0318: Using navPlace and navDate Together #407

merged 24 commits into from
Aug 9, 2024

Conversation

mikeapp
Copy link
Member

@mikeapp mikeapp commented Apr 11, 2023

@glenrobson
Copy link
Member

The cookbook editors had the following comments on the recipe:

So it would look something like this:

NavPlace and NavDate Collection

JSON-LD
<< example >>

The cookbook editors would like a quick look at the changes before it goes to the TRC but are happy for it to go to the May TRC.

Thanks

@triplingual
Copy link
Contributor

(The sub-message on immediately preceding commit should have touched @mikeapp instead. Apologies.)

@glenrobson
Copy link
Member

Add navPlace viewer and then ready to merge.

@glenrobson
Copy link
Member

We should change the collection so that it also has the navDates and navPlaces to allow efficient client processing.

Show collection in the example and links to viewers.

Decision arrived at during cookbook authors call 19 July 2024. Reasoning is partly that we want a viewer to not have to dig into the constituent manifests to get the data and that we want to show how a Collection can be made from manifests that themselves do not have chrono or geo data in them.
@glenrobson glenrobson added the meta: ready-for-recipe Discussion has concluded, recipe to be written label Aug 2, 2024
@glenrobson glenrobson added meta: ready-to-merge Pull request is ready to merge into main branch and removed meta: ready-for-recipe Discussion has concluded, recipe to be written labels Aug 9, 2024
@glenrobson glenrobson merged commit 3fc2742 into master Aug 9, 2024
1 check passed
@glenrobson glenrobson deleted the 0318 branch August 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: approved-by-trc Recipe has been approved by the TRC meta: ready-to-merge Pull request is ready to merge into main branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

navPlace and navDate Together
3 participants