Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path encoding problems on Windows #144

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

azurefx
Copy link

@azurefx azurefx commented Dec 1, 2018

See discussions on JuliaImages/Images.jl Issue 770

@azurefx
Copy link
Author

azurefx commented Dec 7, 2018

Calling setimagefilename() will break TIFF images. Investigating.

@timholy
Copy link
Member

timholy commented Dec 12, 2019

Let's try rebuilding this.

@timholy timholy closed this Dec 12, 2019
@timholy timholy reopened this Dec 12, 2019
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #144 into master will increase coverage by 7.58%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   53.26%   60.85%   +7.58%     
==========================================
  Files           2        2              
  Lines         306      304       -2     
==========================================
+ Hits          163      185      +22     
+ Misses        143      119      -24
Impacted Files Coverage Δ
src/libmagickwand.jl 57.69% <100%> (+2.25%) ⬆️
src/ImageMagick.jl 65.57% <0%> (+15.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4e1c1...69206af. Read the comment docs.

@ViralBShah
Copy link
Contributor

ViralBShah commented Jan 26, 2024

Merge? Or too old and close?

@timholy timholy closed this Jan 27, 2024
@timholy timholy reopened this Jan 27, 2024
@ViralBShah
Copy link
Contributor

3D TIFF: Error During Test at /home/runner/work/ImageMagick.jl/ImageMagick.jl/test/constructed_images.jl:142
  Got exception outside of a @test
  Sanity check on directory count failed, this is probably not a valid IFD offset. `TIFFFetchDirectory' @ error/tiff.c/TIFFErrors/567

@ViralBShah
Copy link
Contributor

Would be nice to have this one working since it fixes a commonly reported issue (but this PR needs more work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants