Distconv channelwise softmax #2148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaman19
force-pushed
the
distconv-channelwise-softmax
branch
from
195cdea
to
53b2eef
Compare
szaman19
force-pushed
the
distconv-channelwise-softmax
branch
2 times, most recently
from
b7de275
to
8ded742
Compare
|
@szaman19 I have fixed the conflicts through the browser interface since attempting to rebase the PR caused some amount of heartburn. Please take a look. |
szaman19
force-pushed
the
distconv-channelwise-softmax
branch
from
d736a53
to
a41d3f7
Compare
|
@bvanessen @tbennun @benson31 Compilation errors should all be fixed. The CI test is currently passing on Lassen. |
szaman19
force-pushed
the
distconv-channelwise-softmax
branch
from
5849d4e
to
0563472
Compare
bvanessen
reviewed
Jun 11, 2024
ci_test/unit_tests/test_unit_layer_channelwise_softmax_distconv.py
Outdated
Show resolved
Hide resolved
tbennun
requested changes
Jun 13, 2024
include/lbann/layers/misc/distconv/distconv_channelwise_softmax.hpp
Outdated
Show resolved
Hide resolved
- Adding boilerplate for distconv adapter - Updated CMakeLists to correct file type
- Updated forward impls for both non-distconv and distconv channelwise_softmax
- CI test failing
…conv is enabled - Updated ReleaseNotes
- Currently building and linking
- CI test passing on Lassen
…v.py Co-authored-by: Brian Van Essen <[email protected]>
szaman19
force-pushed
the
distconv-channelwise-softmax
branch
from
7847e7b
to
66f5ee3
Compare
tbennun
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds distconv support for the channelwise softmax layer.
Should wait till #2145 is merged.