Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ratio3d #13

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature/ratio3d #13

wants to merge 8 commits into from

Conversation

jmikeowen
Copy link
Collaborator

I've updated this branch with master, and it appears the test Cody wrote is doing the same thing in (X,Y,Z) as expected.

image

If we unflip the z generation direction it also looks good:

image

so I think this is ready to go.

jmikeowen pushed a commit that referenced this pull request Aug 6, 2020
* commit '0f74c61ae0d0a09856cc2e061a84e38a4755ea50':
  Adding an ENABLE_DOCS CMake flag which allows choosing whether or not to build the documentation.  Defaults to Off.
  Hardwiring sphinx to be the Spheral built one, and adding a few more dependencies for the docs build.
  Removed a debug message.
  Fixing notations for default options.
  Default readthedocs sphinx theme
  Setting default readthedocs sphinx theme
  Need a symlink called contents.rst for readthedocs.
  Adding support for readthedocs.
  First pass at build instructions.
  Starting rst documentation.
@mdavis36 mdavis36 changed the base branch from master to develop August 12, 2020 16:40
@mdavis36
Copy link
Collaborator

@jmikeowen @antimatterhorn Per the move to a Develop/Release/Master gitflow I have changed the base branch of this PR to develop.

@mdavis36
Copy link
Collaborator

mdavis36 commented Jun 9, 2024

@jmikeowen This PR is 4 years old, should we close it? It can be opened again if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants