Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DIMASSOC object #1029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michal-josef-spacek
Copy link
Contributor

No description provided.

@michal-josef-spacek michal-josef-spacek mentioned this pull request Oct 12, 2024
3 tasks
@rurban
Copy link
Contributor

rurban commented Oct 14, 2024

As smoke/dimassoc-pr1029

@rurban
Copy link
Contributor

rurban commented Oct 14, 2024

test make && make -C test/unit-testing/ dimassoc && (cd test/unit-testing && ./dimassoc; cd -) in smoke/dimassoc-pr1029. osnap_pt is wrong.

unknowns see DIMASSOC.zip

Copy link
Contributor

@rurban rurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt parse. see the unit-tests and the pi logs

include/dwg.h Outdated Show resolved Hide resolved
@michal-josef-spacek
Copy link
Contributor Author

I am trying to test, but I was blocked by #1032

@michal-josef-spacek
Copy link
Contributor Author

Ad make && make -C test/unit-testing/ dimassoc && (cd test/unit-testing && ./dimassoc; cd -):
Yes, all >AC1018 are bad, condition with minimal length of item (35 bytes) to end of block is not working.

test/test-data/example_2018.dwg:

...
trans_space_flag: 0 [B 70]
rotated_type: 0x0 [RC 71]
dimensionobj: (4.2.399) abs:921 [H 330]
DIMASSOC_Ref.rcount1: 0
ref[rcount1].classname: "AcDbOsnapPointRef" [TU 1]
ref[0].osnap_type: 0xd [RC 72]
ref[0].num_xrefs: 1 [BL 0]
ref[rcount1].xrefs[vcount]: (4.2.398) abs:920 [H 331]
ref[0].main_subent_type: 2 [BL 73]
ref[0].main_gsmarker: 0 [BL 91]
ref[0].num_xrefpaths: 0 [BL 0]
ref[0].osnap_dist: 4.13129 [BD 40]
ref[0].osnap_pt: (0, 0, 2e+50) [3BD 10]
ref[0].has_lastpt_ref: 0 [B 75]
DIMASSOC_Ref.rcount1: 1
ref[rcount1].classname: "AcDbOsnapPointRef" [TU 1]
ref[1].osnap_type: 0x1 [RC 72]
ref[1].num_xrefs: 1 [BL 0]
ref[rcount1].xrefs[vcount]: (4.2.398) abs:920 [H 331]
ref[1].main_subent_type: 2 [BL 73]
ref[1].main_gsmarker: 0 [BL 91]
ref[1].num_xrefpaths: 0 [BL 0]
ref[1].osnap_dist: 7.44845 [BD 40]
ref[1].osnap_pt: (0, 0, 2e+50) [3BD 10]
ref[1].has_lastpt_ref: 0 [B 75]
DIMASSOC_Ref.rcount1: 2
ref[rcount1].classname: "AcDbOsnapPointRef" [TU 1]
ref[2].osnap_type: 0x3 [RC 72]
ref[2].num_xrefs: 1 [BL 0]
ref[rcount1].xrefs[vcount]: (4.2.398) abs:920 [H 331]
ref[2].main_subent_type: 2 [BL 73]
ref[2].main_gsmarker: 0 [BL 91]
ref[2].num_xrefpaths: 0 [BL 0]
ref[2].osnap_dist: 4.13129 [BD 40]
ref[2].osnap_pt: (0, 0, 0) [3BD 10]
ref[2].has_lastpt_ref: 0 [B 75]
DIMASSOC_Ref.rcount1: 3
ERROR: bit_read_TU buffer overflow at 170.6 + 112 > 172
ref[rcount1].classname: "" [TU 1]
ref[3].osnap_type: 0x44 [RC 72]
ref[3].num_xrefs: 65 [BL 0]
ERROR: Invalid xrefs size 65. Need min. 520 bits, have 3 for DIMASSOC. Set _size to 0
 object_map{3B4} = 261
 padding: 80/0 (6 bits)
crc: 3461 [RSx]
 check_CRC 121033-121226 = 193: 3461 == 3461

It need to end before last block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants