-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: changing servicetype image/spectrum to sia/ssa #171
Conversation
This should be ready to go. The content still needs an upgrade to mention SIA2, but that is beyond the scope of this PR. With this in, I think astropy/pyvo#449 should be given the green light and get merged. |
If we bump the required pyvo version to 1.5.3, we will be able to update these examples to use |
@tomdonaldson - This is ready to go. CI is expected to fail due to some unrelated server issues at heasarc (CI was passing two weeks ago, and only doc changes have been made since then) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bsipocz. This seems to have caught all occurrences!
Proof of concept to see if how proposed changes of pyvo would look in practice
(this is just sed-ing through the code, the narrative text may need some updates, too)
(Also, I wonder why we only have
'sia'
but not'sia1'
, as the latter would be the correct, non-ambiguous one, thus I'm opening an upstream, pyvo PR for that)closes #170