Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: changing servicetype image/spectrum to sia/ssa #171

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Jul 29, 2024

Proof of concept to see if how proposed changes of pyvo would look in practice

(this is just sed-ing through the code, the narrative text may need some updates, too)

(Also, I wonder why we only have 'sia' but not 'sia1', as the latter would be the correct, non-ambiguous one, thus I'm opening an upstream, pyvo PR for that)

closes #170

@bsipocz
Copy link
Contributor Author

bsipocz commented Jul 31, 2024

This should be ready to go. The content still needs an upgrade to mention SIA2, but that is beyond the scope of this PR.

With this in, I think astropy/pyvo#449 should be given the green light and get merged.

@bsipocz bsipocz added compatibility update To reflect on changing dependencies upstream labels Jul 31, 2024
@bsipocz
Copy link
Contributor Author

bsipocz commented Aug 8, 2024

If we bump the required pyvo version to 1.5.3, we will be able to update these examples to use 'sia1' vs 'sia', but overall that maybe too fresh of a release to require (it's not even released, but planned to be out in the early autumn)

@bsipocz
Copy link
Contributor Author

bsipocz commented Aug 13, 2024

@tomdonaldson - This is ready to go. CI is expected to fail due to some unrelated server issues at heasarc (CI was passing two weeks ago, and only doc changes have been made since then)

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bsipocz. This seems to have caught all occurrences!

@bsipocz bsipocz merged commit 4a3d8ca into NASA-NAVO:main Aug 15, 2024
1 of 11 checks passed
@bsipocz bsipocz deleted the MAINT_image_to_sia branch August 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility update To reflect on changing dependencies upstream
Projects
None yet
2 participants