-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcbeautify: init at 1.4.0 #286284
xcbeautify: init at 1.4.0 #286284
Conversation
4b8ac60
to
d07a5c3
Compare
0c059aa
to
40d7b79
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3394 |
40d7b79
to
035b950
Compare
035b950
to
e1472e1
Compare
3cf7b18
to
c673cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃 👍
It'd be good to have another mac user to actually run nixpkgs-review
on this and independently test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a Darwin-only software, I can't "approve" it besides reading the code.
40ff583
to
4d44232
Compare
4d44232
to
100c2c3
Compare
What would be the next steps to get this merged? |
Description of changes
xcbeautify is a tool to format
xcodebuild
output.derivation of
xcbeautify
in status-mobile repo -> https://github.com/status-im/status-mobile/blob/develop/nix/pkgs/xcbeautify/default.nixThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.