Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcbeautify: init at 1.4.0 #286284

Merged
merged 2 commits into from
Feb 15, 2024
Merged

xcbeautify: init at 1.4.0 #286284

merged 2 commits into from
Feb 15, 2024

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Feb 4, 2024

Description of changes

xcbeautify is a tool to format xcodebuild output.

derivation of xcbeautify in status-mobile repo -> https://github.com/status-im/status-mobile/blob/develop/nix/pkgs/xcbeautify/default.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/83

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3394

nixos/doc/manual/release-notes/rl-2405.section.md Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
@siddarthkay siddarthkay force-pushed the init/xcbeautify branch 3 times, most recently from 3cf7b18 to c673cd8 Compare February 10, 2024 03:57
Copy link
Contributor

@lelgenio lelgenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 👍

It'd be good to have another mac user to actually run nixpkgs-review on this and independently test.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a Darwin-only software, I can't "approve" it besides reading the code.

pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcbeautify/package.nix Outdated Show resolved Hide resolved
@siddarthkay
Copy link
Contributor Author

What would be the next steps to get this merged?

@marsam marsam merged commit dc302b0 into NixOS:master Feb 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants