python3Packages.nbdime: fix build for jupyter-server 2.13 #298668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build python311Packages.nbdime |
natsukium
reviewed
Mar 26, 2024
| @@ -31,6 +31,11 @@ buildPythonPackage rec { | |||
| hash = "sha256-8adgwLAMG6m0lFwWzpJXfzk/tR0YTzUbdoW6boUCCY4="; | |||
| }; | |||
|
|
|||
| patches = [ | |||
| # see https://github.com/jupyter/nbdime/issues/749 | |||
There was a problem hiding this comment.
I would like a comment on what this patch does, even without looking at the link.
There was a problem hiding this comment.
I've added a comment now
see also the upstream issue for this: jupyter/nbdime#749
999eagle
force-pushed
the
fix/python-nbdime
branch
from
b9859d2
to
9ecd9e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
upstream issue for this where the patch was mentioned: jupyter/nbdime#749
maybe this should also be merged into #297752
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.