angular-language-server: init at 18.2.0

[bornedj]

Description of changes

Adds the angular language server for neovim, emacs, and eclipse users managing their own lsps via extraPackages.

homepage: https://github.com/angular/vscode-ng-language-service#readme

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[lelgenio]

Thanks for your first contribution!

It's a general consensus on nixpkgs to no longer add packages to nodePackages, and instead prefer to add them as standalone packages: #229475
I thinks this should be better communicated....

angular/language-server is packaged with yarn, I assume you could use the newly added yarn-specific hooks to package it: https://nixos.org/manual/nixpkgs/unstable/#javascript-yarn

[bornedj]

1. My bad I wasn't aware of that decision and was following the documentation here. Would it be useful to open a documentation PR to add a reference to issue Repackage node2nix generated packages using buildNpmPackage #229475 within the language-frameworks javascript section?

2. I would be happy to package it via yarn. Would you prefer that I do that on another branch and PR and make reference to this one, or would it be better to revert my commit and continuing working on the same branch/PR?

[SuperSandro2000]

2. Would you prefer that I do that on another branch and PR and make reference to this one

that would be fine

or would it be better to revert my commit and continuing working on the same branch/PR?

You can continue this PR but it must be force pushed. We want a cleanish history.

[lelgenio]

1. My bad I wasn't aware of that decision and was following the documentation here. Would it be useful to open a documentation PR to add a reference to issue

Ref: #319341

[bornedj]

Reopening PR as it's been packaged as a derivation with mkYarnPackage.

[lelgenio]

Suggested change

	buildPhase = ''
	runHook preBuild
	tsc -b && yarn bazel build :npm
	runHook postBuild
	'';
	yarnBuildScript = "compile";

https://github.com/angular/vscode-ng-language-service/blob/1e4c92c156c0f1cdd2c9510000a6f41f070dd123/package.json#L224C6-L224C13

Assuming this would work.

[bornedj]

Oddly, using the yarnBuildHook and package.json script directly results in yarn attempting to install bazel on my machine. Explicitly doing the command instead of the equivalent script does not.

[dotlambda]

That's because bazel isn't even run:

/nix/store/91d27rjqlhkzx7mhzxrir1jcr40nyc7p-stdenv-linux/setup: line 1709: tsc: command not found

[lelgenio]

Suggested change

	yarnConfigHook
	yarnInstallHook
	yarnConfigHook
	yarnBuildHook
	yarnInstallHook

[dotlambda]

Suggested change

	description = "Lsp for angular completions, AOT diagnostic, quick info and go to definitions";
	description = "LSP for angular completions, AOT diagnostic, quick info and go to definitions";

[dotlambda]

That's because bazel isn't even run:

/nix/store/91d27rjqlhkzx7mhzxrir1jcr40nyc7p-stdenv-linux/setup: line 1709: tsc: command not found