Transitive rebinding #413
Open
Transitive rebinding #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this comment is out of date, since in e.g. test_multi_rebind _rebound_subfragment_params does indeed end up with two ParamHandles for the "value" parameter.
…esolved source. This is not sensitive to the order in which rebinds happen, and the ultimate source can be found using _find_param_source. This doesn't currently matter, but future code might find this behaviour less surprising. Note that _rebound_subfragment_params *is* sensitive to the order in which binds happen. This does not create redundant stores however, because init_params only reads _get_all_handles_for_param for free params.
This doesn't currently matter, but might be confusing in future otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for transitive rebinding of parameters.
If fragment A has two children, B and C, support already existed for overriding
C.my_paramto depend onB.my_paramthenB.my_paramto depend onA.my_param.This PR lets you do it the other way around, giving the same final result but reversing the call order so you can first bind
B.my_paramtoA.my_param, thenC.my_paramtoB.my_param.We found this need pop up when wanting to bind parameters between subfragments at the same hierarchical level.