Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(action): (probably) fix preview action #419

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix(action): (probably) fix preview action #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 3 additions & 25 deletions .github/workflows/deploy-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,12 @@ jobs:
deployments: write
pull-requests: write
steps:
- name: "add comment"
if: github.event_name != 'push'
uses: mshick/add-pr-comment@v2
with:
message-id: "cloudflare-pages-preview"
message: |
## Deploying with [<img alt="Cloudflare Pages" width="16" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png">](https://pages.dev) Cloudflare Pages

| Latest commit: | ${{ github.sha }} |
|---------------------------------|------------------------|
| Status: | 🔨 Building... |
---
- name: "checkout"
uses: "actions/checkout@v4"
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
- name: "setup pnpm"
uses: "pnpm/action-setup@v4"
- name: "setup node"
Expand All @@ -49,17 +39,5 @@ jobs:
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
projectName: "papermc-docs"
deploymentName: "Preview"
gitHubToken: ${{ secrets.GITHUB_TOKEN }}
directory: "build"
- name: "add comment"
uses: "mshick/add-pr-comment@v2"
with:
message-id: "cloudflare-pages-preview"
message: |
## Deploying with [<img alt="Cloudflare Pages" width="16" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png">](https://pages.dev) Cloudflare Pages

| Latest commit: | ${{ github.sha }} |
|---------------------------------|------------------------|
| Status: | ✅ Deploy successful! |
| Preview URL: | [${{ steps.cloudflare-publish.outputs.url }}](${{ steps.cloudflare-publish.outputs.url }}) |

[View logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
2 changes: 1 addition & 1 deletion config-specs/paper/paper-global.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ unsupported-settings:
description: >-
Whether the server should skip damage ticks when entities are blocking damage
via a shield. While Vanilla does process a damage tick, this behavior was a long
standing bug in paper. Enabling this option means that the damage tick will be
standing bug in Paper. Enabling this option means that the damage tick will be
skipped, which may result in rapid damage on shields due to the missing invulnerability.
perform-username-validation:
default: "true"
Expand Down
Loading