Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dnsdist 1.9 #117

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

lpmhouben
Copy link

Adding support for the dnsdist-19 repo was the easy part; fixing the molecule tests for Debian 11 and 12 was a lot more work.

@lpmhouben
Copy link
Author

(The ansible-lint error involves a spacing issue in, I shit you not, the .ansible-lint file. I haven't touched it)

@lpmhouben
Copy link
Author

Went in and cleared it up. Apparently YAML wants two spaces before an inline comment now.

meta/main.yml Outdated Show resolved Hide resolved
vars/main.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@npmdnl npmdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the suggested changes.
Take note that v1.9.0 has not been officially released yet

@lpmhouben
Copy link
Author

Thanks for the suggestions, they look good.

I'm headed out-of-country tomorrow evening; anything I haven't fixed before then won't be fixed for another week.

lpmhouben and others added 2 commits January 9, 2024 18:41
Additional changes to cover yum as well, thanks to @npmdl

Co-authored-by: npmdnl <[email protected]>
Removed Jessie reference

Co-authored-by: npmdnl <[email protected]>
@npmdnl
Copy link
Contributor

npmdnl commented Apr 8, 2024

Hello @lpmhouben in order to merge this push request you need to solve conflicting files and commit changes. TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants