Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use platform-python for dnf provenance generation #70

Merged
merged 1 commit into from
Jan 18, 2024
Merged

use platform-python for dnf provenance generation #70

merged 1 commit into from
Jan 18, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Jan 16, 2024 •
edited
Loading

This PR changes two files. Either change fixes the problem (import dnf failing in the provenance script), so we need to choose.

@Habbie
Copy link
Member Author

Habbie commented Jan 16, 2024 

09:29Z <zeha> Habbie: if you need to use dnf from python (and thats a valid api), it would seem to be sensible to use usr/libexec/platform-python 
09:29Z <zeha> Habbie: might want a comment

@wojas
Copy link
Member

wojas commented Jan 16, 2024

The platform-python approach is more robust than pinning it to a python version that has been EOL for over 2 years.

We are currently missing EL 9 in the tests.

@Habbie
Copy link
Member Author

Habbie commented Jan 18, 2024

The platform-python approach is more robust than pinning it to a python version that has been EOL for over 2 years.

Yes, agreed. Will take out the other change.

@Habbie Habbie changed the title DO NOT MERGE two fixes for our dnf problem use platform-python for dnf provenance generation Jan 18, 2024
@Habbie Habbie marked this pull request as ready for review January 18, 2024 08:02
@Habbie
Copy link
Member Author

Habbie commented Jan 18, 2024

done

@Habbie
Copy link
Member Author

Habbie commented Jan 18, 2024

We are currently missing EL 9 in the tests.

I'll give this a shot

@Habbie Habbie mentioned this pull request Jan 18, 2024
Merged
@Habbie Habbie merged commit 1ab1e8f into PowerDNS:master Jan 18, 2024
1 check passed
@Habbie Habbie deleted the fix-dnf-python branch January 18, 2024 10:05
@Habbie Habbie mentioned this pull request May 31, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojas wojas wojas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Habbie @wojas